bcollet/apc-p15-tool
1
0
Fork 0
mirror of https://github.com/gregtwallace/apc-p15-tool.git synced 2025-01-22 08:14:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

cleanup extra args logging / logic

Browse source
This commit is contained in:
Greg T. Wallace 2024-02-02 18:35:20 -05:00
parent 3b611b06e4
commit d94a10b949
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/app/app.go
View file

@ -54,13 +54,10 @@ func Start() {
exitCode = 0 exitCode = 0
app.logger.Info("\n\n", ffhelp.Command(app.cmd)) app.logger.Info("\n\n", ffhelp.Command(app.cmd))
} else if errors.Is(err, ErrExtraArgs) {
// extra args (will log elsewhere, so no need to log err again)
app.logger.Info("\n\n", ffhelp.Command(app.cmd))
} else if errors.Is(err, ff.ErrDuplicateFlag) || } else if errors.Is(err, ff.ErrDuplicateFlag) ||
errors.Is(err, ff.ErrUnknownFlag) || errors.Is(err, ff.ErrUnknownFlag) ||
errors.Is(err, ff.ErrNoExec) { errors.Is(err, ff.ErrNoExec) ||
errors.Is(err, ErrExtraArgs) {
// other error that suggests user needs to see help // other error that suggests user needs to see help
app.logger.Error(err) app.logger.Error(err)
app.logger.Info("\n\n", ffhelp.Command(app.cmd)) app.logger.Info("\n\n", ffhelp.Command(app.cmd))

3
pkg/app/cmd_create.go
View file

@ -15,8 +15,7 @@ const createDefaultOutFilePath = "apctool.p15"
func (app *app) cmdCreate(_ context.Context, args []string) error { func (app *app) cmdCreate(_ context.Context, args []string) error {
// extra args == error // extra args == error
if len(args) != 0 { if len(args) != 0 {
app.logger.Errorf("create: failed, extra args (%d) present", len(args)) return fmt.Errorf("create: failed, %w (%d)", ErrExtraArgs, len(args))
return ErrExtraArgs
} }
// key must be specified // key must be specified