bcollet/apc-p15-tool
1
0
Fork 0
mirror of https://github.com/gregtwallace/apc-p15-tool.git synced 2025-01-22 08:14:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

header: fix (needed proper type conversion)

Browse source
This commit is contained in:
Greg T. Wallace 2024-01-27 11:35:36 -05:00
parent a626d84fdb
commit dd6c6bd442
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
pkg/app/file_header.go
View file

@ -58,17 +58,18 @@ func makeFileHeader(p15File []byte) ([]byte, error) {
// check sums (CRC Table) // check sums (CRC Table)
checksumTable := crc16.MakeTable(crc16.CRC16_XMODEM) checksumTable := crc16.MakeTable(crc16.CRC16_XMODEM)
// NOTE: 16 bit checksums are moved to 32 bit int with sign-extension by converting
// to int16 and then to uint32
// file checksum // file checksum
fileChecksum := make([]byte, 4) fileChecksum := make([]byte, 4)
binary.LittleEndian.PutUint16(fileChecksum, crc16.Checksum(p15File, checksumTable)) binary.LittleEndian.PutUint32(fileChecksum, uint32(int16(crc16.Checksum(p15File, checksumTable))))
copy(header[220:], fileChecksum) copy(header[220:], fileChecksum)
// header checksum // header checksum
headerChecksum := make([]byte, 4) headerChecksum := make([]byte, 4)
binary.LittleEndian.PutUint16(headerChecksum, crc16.Checksum(header[:224], checksumTable)) binary.LittleEndian.PutUint32(headerChecksum, uint32(int16(crc16.Checksum(header[:224], checksumTable))))
copy(header[224:], headerChecksum) copy(header[224:], headerChecksum)
// this was in original code but
return header, nil return header, nil
} }