bcollet/socat
1
0
Fork 0
mirror of https://repo.or.cz/socat.git synced 2025-01-09 06:22:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Option stderr leaked a temporary FD into child process

Browse source
This commit is contained in:
Gerhard Rieger 2023-06-12 12:25:54 +02:00
parent 80f4aa8bcd
commit b3dde9a009
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGES
View file

@ -37,6 +37,9 @@ Corrections:
The FDs of the socketpair that queues messages from signal handlers The FDs of the socketpair that queues messages from signal handlers
lacked FD_CLOEXEC and thus leaked into EXEC and SYSTEM child processes. lacked FD_CLOEXEC and thus leaked into EXEC and SYSTEM child processes.
Option stderr on addresses EXEC and SYSTEM uses a temporary FD. It
lacked the FD_CLOEXEC setting and thus leakt into child processes.
Features: Features:
VSOCK, VSOCK-L support options pf, socktype, prototype (currently VSOCK, VSOCK-L support options pf, socktype, prototype (currently
useless) useless)

1
error.c
View file

@ -472,6 +472,7 @@ int diag_dup(void) {
return -1; return -1;
} }
newfd = dup(fileno(diagopts.logfile)); newfd = dup(fileno(diagopts.logfile));
Fcntl_l(newfd, F_SETFD, FD_CLOEXEC);
if (diagopts.logfile != stderr) { if (diagopts.logfile != stderr) {
fclose(diagopts.logfile); fclose(diagopts.logfile);
} }